Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for validating aspects of PCZT bundles #147

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Add methods for validating aspects of PCZT bundles #147

merged 2 commits into from
Dec 13, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Dec 13, 2024

No description provided.

daira
daira reviewed Dec 13, 2024
View reviewed changes
src/pczt/verify.rs Outdated Show resolved Hide resolved
daira
daira approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with suggestion.

nuttycom
nuttycom approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 231f819 modulo @daira's suggestions.

@str4d str4d merged commit 5bf2578 into main Dec 13, 2024
23 checks passed
@str4d str4d deleted the pczt-verifier branch December 13, 2024 08:11
daira
daira reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@str4d @nuttycom @daira